-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor UX fixes #1672
Some minor UX fixes #1672
Conversation
Add some a `print_proof_summary`, a `goal_num`, and a `write_goal` tactic to help during the proof exploration process.
assertions. We should check/update the corresponding information for JVM points-tos.
satisfiability checking.
symbolic execution. This is generally unsound, but may be useful in proof exploration and construction to focus in on just the stated correcness specifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall. We should consider including integration tests for some of the top-level commands that lend themselves to that (goal_num
stands out), and perhaps updating the manual to mention the new commands as well.
I thought about testing, but its not totally clear to me what would make a good test for some of these... do you have an idea in mind for |
I'm going to merge this now while everything is green. @chameco, if you have some concrete ideas for tests you'd like to see, I'm happy to add them later. |
👍. I have some ideas for testing |
We already have For better or worse, the proof tactics we have for manipulating goals don't generate fresh numbers, those only come from the initial enumeration inside a |
Ah, I hadn't run |
Agreed, the whole thing is kind of a mess. It would be nice to have better ways to handle the issue of goal identification, numbering the goals as we do now is a crude solution at best. #1195 has some ideas along these lines. I like the idea of a combinator that adds a user-configurable annotation "tag" to all the goals generated by things in it's scope. |
Some minor, but important, fixes for the user experience.