-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an eval_int
command to the remote API and Python interface
#1660
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
84f5da3
Add an `eval_int` command to the remote API and Python interface
chameco 27bd3b7
Add `eval_bool`
chameco 99c61d9
Fix type error
chameco 1fd1882
Update SAW.rst
chameco 44d9e66
Merge branch 'master' into sb/remote-eval-int
chameco 24276e3
Refactor a bit
chameco 0e40137
Address review comments
chameco b374194
Update changelogs
chameco 6b38fcd
data -> newtype
chameco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
from cryptol import cryptoltypes | ||
import saw_client as saw | ||
|
||
import unittest | ||
from pathlib import Path | ||
|
||
|
||
def cry(exp): | ||
return cryptoltypes.CryptolLiteral(exp) | ||
|
||
class ProverTest(unittest.TestCase): | ||
|
||
def test_provers(self): | ||
saw.connect(reset_server=True) | ||
|
||
if __name__ == "__main__": saw.view(saw.LogResults()) | ||
|
||
expr1 = cry('(6 : [8]) * 7') | ||
chameco marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.assertEqual(saw.eval_int(expr1), 42) | ||
|
||
expr2 = cry('(1 < 2) : Bit') | ||
chameco marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.assertTrue(saw.eval_bool(expr2)) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's curious that the Mypy run in CI didn't catch this. Testing locally: if I remove the
isinstance
check, I get the expected type error ("returning Any from a function declared to return bool"), but I don't get any error if theisinstance
check mismatches the declared return type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
bool
is anint
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that would explain it. TIL. Thanks!