Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve URI-based names when loading the external SAWCore format #1658

Merged
merged 3 commits into from
May 10, 2022

Conversation

chameco
Copy link
Contributor

@chameco chameco commented May 5, 2022

No description provided.

@chameco chameco requested a review from andreistefanescu May 6, 2022 18:12
@RyanGlScott
Copy link
Contributor

Is this motivated by #1581?

@chameco
Copy link
Contributor Author

chameco commented May 9, 2022

Yes, although the main motivation is a collection of issues (#1112, #1113, #1257, maybe others) related to serialization of SAWCore terms to the external format being somewhat broken. While there are still broader questions relating to how we should handle names when saving/loading terms, this change at least makes it possible to use URI-named terms in the same way as module-named terms.

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. In that case, it sounds like this is laying the groundwork for other improvements, and the change itself looks pretty straightforward.

Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chameco chameco merged commit e1d8d9d into master May 10, 2022
@mergify mergify bot deleted the sb/extcore-resolve branch May 10, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants