Search for uninterpreted names in both Cryptol and SAWCore naming environments #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix a particular bug? If so, can a test case be added? Also, does this patch change the warning observed in #1376? |
|
It looks like this does address the issue described in #1112. |
chameco
added
the
PR: ready to merge
|
@robdockins That's definitely unintentional - I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, specifying an uninterpreted name somewhat unintuitively searches first in the Cryptol environment and then in the SAWCore environment if the first search fails. This allows Cryptol names to "shadow" SAWCore names. This PR changes this scheme to search both environments, treating all names found as uninterpreted.
(This new approach is still far from ideal. We should consider adding more ways to precisely specify uninterpreted names, especially considering the new URI-based model for SAWCore names.)