Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prove_prop command #1656

Merged
merged 5 commits into from
May 12, 2022
Merged

Add prove_prop command #1656

merged 5 commits into from
May 12, 2022

Conversation

chameco
Copy link
Contributor

@chameco chameco commented May 5, 2022

No description provided.

chameco added 2 commits May 5, 2022 12:53
@chameco
Add a "prove_prop" command
f32710a 
For proving terms that have already been translated into proposition types
@chameco
Whoops, fix Interpreter.hs to reflect a name change
919c5f1
@chameco chameco requested a review from andreistefanescu May 6, 2022 18:12
@RyanGlScott
Copy link
Contributor

At a quick glance, I'm not sure what the difference between this and prove_print is, given that they have the same type signatures. Perhaps a test case and a description in the SAW manual would help clarify things.

andreistefanescu
andreistefanescu approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/SAWScript/Builtins.hs Show resolved Hide resolved
src/SAWScript/Interpreter.hs Outdated Show resolved Hide resolved
@andreistefanescu
Copy link
Contributor

I searched for tests for offline_extcore, and found nothing. At some point, let's add some tests, including one for this command, but, I don't think this change should be delayed.

@chameco chameco merged commit 143c48f into master May 12, 2022
@mergify mergify bot deleted the sb/proveprop branch May 12, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chameco @RyanGlScott @andreistefanescu