WIP: Heapster/try unifying arrays #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abakst
force-pushed
the
heapster/arrays-unify
branch
from
dd6d401 to
12e1d87
Compare
|
Note the current CI failure is precisely the current state of the PR (type checking failure in rust_data), which needs investigation |
added 5 commits
May 2, 2022 10:45
…" method to convert symbol names to strings
… supposed to say "not a tuple"
…n incorrect translation; also fixed up the comments on translateLLVMValue to help clarify what it is supposed to return
…ion used by the rule having the same shape as the array permission cell; changed the call to this rule in proveLLVMArray to ensure this property holds
eddywestbrook
approved these changes
May 2, 2022
eddywestbrook
added
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found when checking rust_data.rs, where the array on the RHS may not have its lifetime/rw modality solved