Heapster: niche optimization for sums with an uninhabited type #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 20, 2022 15:48
…ed out get_out because it produces inline assembly that SAW currently cannot handle; added extract_from_result_infallible example function
…e where one branch is uninhabited to just the other type, without the tag
eddywestbrook
added
the
subsystem: heapster
ChrisEPhifer
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Rust-to-Heapster type translation to handle sum types where one side of the sum is an uninhabited type, which Rust lays out as just the other branch of the sum without the tag. So, for example, the Rust type
Result<Infallible,X>is just represented asX, whereInfallibleis an empty type with no constructors.