Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heapster false permission and shape syntax #1630

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

eddywestbrook
Copy link
Contributor

Unfortunately, when we added support for the false permission and false shape to Heapster, we forgot to add parser support for writing these. This PR fixes this problem.

@eddywestbrook eddywestbrook added the subsystem: heapster Issues specifically related to memory verification using Heapster label Apr 20, 2022
Copy link
Member

@ChrisEPhifer ChrisEPhifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ChrisEPhifer ChrisEPhifer added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Apr 20, 2022
@mergify mergify bot merged commit 4c5ebfc into master Apr 20, 2022
@mergify mergify bot deleted the heapster/false-perm-syntax branch April 20, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants