-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mr Solver support for monadic Cryptol specs #1609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Cryptol abstract types
…s, where the translation of the types were not getting applied
…an beta normalizing the entire output term
…eing called is not unfolded during normalization; also added a special case for normalizing multiArgFixM
…n that can normalize open terms
… refines a cryptol version of its specification
eddywestbrook
added
the
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
label
Mar 11, 2022
m-yac
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
m-yac
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for Mr Solver to work on specifications extracted from Cryptol. This required the following changes:
cryptol_add_prim
andcryptol_add_prim_type
SAW script commands for specifying the translations of Cryptol primitives and primitive types, respectivelyeither
elimination function;assertFiniteM
in theCryptolM
SAW core module to use aMaybe
type;mrNormOpenTerm
function to Mr Solver and changed Mr Solver to use it instead ofscWhnf
to normalize terms with data type assumptions; andlinked_list_mr_solver.saw
that uses Mr Solver to prove thatis_elem
refines a cryptol version of its specification