-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mr Solver precondition hints #1605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int in the spec rather than with a separate mr_solver_set_precond command
… mrSetEVarClosed to have a more understandable error message
…nvironments; changed mr_solver command to remember refinements that have been proved
m-yac
added
the
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
label
Mar 8, 2022
…king correctly on some of its helper functions...
m-yac
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a few nitpicks, if you don't want to have to wait for the CI, I'm happy to just include the changes in my upcoming PR.
eddywestbrook
added
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
and removed
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
labels
Mar 8, 2022
m-yac
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: MRSolver
Issues related to the Mr. Solver monadic-recursive solver in Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for "precondition hints" to Mr Solver. These hints are in the form of calls to the dummy function
precondHint
as the top level of the definition of a recursive function, and are used to communicate loop invariants to Mr Solver.This PR also fixes a bug in the
smalledBitSetElem
function in the SAW core pretty-printer.