Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mr Solver precondition hints #1605

Merged
merged 16 commits into from
Mar 9, 2022
Merged

Mr Solver precondition hints #1605

merged 16 commits into from
Mar 9, 2022

Conversation

eddywestbrook
Copy link
Contributor

This PR adds support for "precondition hints" to Mr Solver. These hints are in the form of calls to the dummy function precondHint as the top level of the definition of a recursive function, and are used to communicate loop invariants to Mr Solver.

This PR also fixes a bug in the smalledBitSetElem function in the SAW core pretty-printer.

@eddywestbrook eddywestbrook requested a review from m-yac March 7, 2022 23:45
@m-yac m-yac added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label Mar 8, 2022
Copy link
Contributor

@m-yac m-yac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a few nitpicks, if you don't want to have to wait for the CI, I'm happy to just include the changes in my upcoming PR.

src/SAWScript/Prover/MRSolver/Monad.hs Outdated Show resolved Hide resolved
src/SAWScript/Prover/MRSolver/Monad.hs Outdated Show resolved Hide resolved
src/SAWScript/Prover/MRSolver/Monad.hs Outdated Show resolved Hide resolved
src/SAWScript/Prover/MRSolver/Solver.hs Show resolved Hide resolved
@eddywestbrook eddywestbrook added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run and removed PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Mar 8, 2022
@m-yac m-yac added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Mar 8, 2022
@mergify mergify bot merged commit 362bb51 into master Mar 9, 2022
@mergify mergify bot deleted the mr-solver/preconditions branch March 9, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants