Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRSolver] Split Mr. Solver work into multiple files #1596

Merged
merged 2 commits into from
Feb 23, 2022
Merged

[MRSolver] Split Mr. Solver work into multiple files #1596

merged 2 commits into from
Feb 23, 2022

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Feb 22, 2022

This PR splits MRSolver.hs into multiple files under a MRSolver subdirectory. This PR does not change any code, only moves code around. It does add some module and section comments.

@m-yac m-yac requested a review from eddywestbrook February 22, 2022 22:48
eddywestbrook
eddywestbrook approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a great way to refactor this code.

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Feb 23, 2022
@mergify mergify bot merged commit b3d9a3b into master Feb 23, 2022
@mergify mergify bot deleted the mr-solver/reorg branch February 23, 2022 01:11
@m-yac m-yac added the subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywestbrook eddywestbrook eddywestbrook approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: MRSolver Issues related to the Mr. Solver monadic-recursive solver in Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-yac @eddywestbrook