Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SAW core bitvector notations #1590

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Added support for SAW core bitvector notations #1590

merged 4 commits into from
Feb 18, 2022

Conversation

eddywestbrook
Copy link
Contributor

This change adds support for SAW core bitvector literals, written either in hexadecimal as 0xXXXX where each X is a hex digit or in binary as 0bBBBBBBBB where each B is either a 0 or a 1.

added support for SAW core bitvector notation 0xXXXX and 0bBBBBB, bot…
0a0aa7a 
…h in the SAW core parser and pretty-printer
@eddywestbrook eddywestbrook requested a review from yav February 18, 2022 20:42
robdockins
robdockins approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddywestbrook eddywestbrook added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem labels Feb 18, 2022
@mergify mergify bot merged commit a134e4a into master Feb 18, 2022
@mergify mergify bot deleted the feature/bitvector-notation branch February 18, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

@brianhuffman brianhuffman Awaiting requested review from brianhuffman

@yav yav Awaiting requested review from yav

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: saw-core Issues related to the saw-core representation or the saw-core subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddywestbrook @yav @robdockins