Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodule versions. #1583

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Update submodule versions. #1583

merged 1 commit into from
Feb 15, 2022

Conversation

brianhuffman
Copy link
Contributor

No description provided.

@brianhuffman brianhuffman added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run PR: submodule bump Pull requests that include a submodule bump labels Feb 15, 2022
@yav yav self-requested a review February 15, 2022 18:18
robdockins
robdockins approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, other than the CI timeout. Would be good to know if that's just standard timing fluctuation or if there is something real going on there.

@yav yav removed their request for review February 15, 2022 18:19
@brianhuffman brianhuffman removed the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Feb 15, 2022
@brianhuffman
Copy link
Contributor Author

I looked over the logs, and it looks like it's just ordinary timing fluctuation, perhaps due to server load. Comparing the time stamps with the corresponding points in the log for the previously-merged PR, I can see that everything is just running 10-30% slower in this run, even non-haskell things like running Yices.

This failure probably means that our timeouts are set too low in CI.

@brianhuffman brianhuffman merged commit 64cf8b1 into master Feb 15, 2022
@mergify mergify bot deleted the update-deps branch February 15, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
PR: submodule bump Pull requests that include a submodule bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhuffman @robdockins