Simple loop fixpoint2 #1553
Merged
Simple loop fixpoint2 #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
force-pushed
the
simple-loop-fixpoint2
branch
from
a156d15 to
fef99b7
Compare
|
@andreistefanescu, any ideas on how to make the new test faster? As I watch the CI, I'm seeing the awslc task is taking about 70 minutes building before it gets to the phase where it actually starts running the SAW proofs. |
robdockins
reviewed
Mar 4, 2022
src/SAWScript/Crucible/LLVM/X86.hs
Outdated
| let uninterpreted_constants = foldMap | ||
| (viewSome $ Set.map (mapSome $ W4.varExpr sym) . W4.exprUninterpConstants sym) | ||
| (Some condition : body_exprs) | ||
| let filtered_uninterpreted_constants = Set.toList $ Set.filter |
There was a problem hiding this comment.
@andreistefanescu, can you say a little bit about what's going on here with this filtering function?
robdockins
force-pushed
the
simple-loop-fixpoint2
branch
from
61f7fba to
d546702
Compare
|
On a second look, I think the proofs are getting interleaved with compiling, so it isn't spending a full hour on compiles the way I thought initially. We should still maybe consider ways to speed up the CI, but it isn't as dire as I thought. |
|
@kquick, mostly interested in your thoughts about the CI impact |
robdockins
force-pushed
the
simple-loop-fixpoint2
branch
from
d546702 to
321e1ed
Compare
robdockins
approved these changes
Mar 14, 2022
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.