Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heapster: use unsafeAssert for translating BVProps known to hold #1544

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Heapster: use unsafeAssert for translating BVProps known to hold #1544

merged 3 commits into from
Dec 20, 2021

Conversation

eddywestbrook
Copy link
Contributor

This PR changes the translation of the Impl1_TryProveBVProp rule for BVProps that are known to hold statically so that they call unsafeAssert, rather than requiring them to be proved by the automation later. The issue was that SAW core equalities on bitvectors do not compute, even though they do in Coq, but translating to unsafeAssert solves the problem in SAW core, and these calls are then translated to Coq reflexivity proofs.

added special cases in the translation of BVProps that are statically…
eccfa7e 
… known to hold to translate the SAW core unsafeAssert function
@eddywestbrook eddywestbrook requested a review from m-yac December 19, 2021 15:01
@eddywestbrook
Copy link
Contributor Author

Whoops, the solveUnsafeAssert tactic doesn't work for proofs of 0 < x.

m-yac
m-yac approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@m-yac m-yac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like how the additions to SAWCoreBitvectors mirror the cases of bvCouldBeLt.

@m-yac m-yac added subsystem: heapster Issues specifically related to memory verification using Heapster PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Dec 20, 2021
@mergify mergify bot merged commit 295bf13 into master Dec 20, 2021
@mergify mergify bot deleted the heapster/unsafeAssert-in-translation branch December 20, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-yac m-yac m-yac approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddywestbrook @m-yac