Heapster: Add support for the trivially false permission #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisEPhifer
added
type: enhancement
|
In order to correctly support Rust types, we actually need a bit more than what this PR originally contained. Namely, we need a notion of a "false shape". I'll be removing the ready-to-merge label and updating the title to reflect this is a WIP. |
ChrisEPhifer
removed
the
PR: ready to merge
ChrisEPhifer
changed the title
There was a problem hiding this comment.
It looks like this does not have a recombinePermConj case for recombining a shape that contains false. This is needed in order to have calls to Rust functions with ! return type not continue type-checking after the function returns (because it doesn't return).
…tion of false elimination implication rules
…typecheck currently
… byte-sized eq perms instead of one giant eq perm for the whole string, which seems to fix some endianness issues
ChrisEPhifer
added
the
PR: ready to merge
ChrisEPhifer
changed the title
ChrisEPhifer
removed
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
ValuePerm,ValPerm_False, which represents the trivially false value permission. It furthermore contains the relevant translations, additions to the implication prover, and conversions from Rust types (i.e. the never type,!).The one thing I'm unsure of is the weight I've assigned to the success of a
PermImplstep that is false elimination - or whether it matters as long as the weight is non-zero. Guidance on this for future reference is most welcome :)