Heapster bugfixes for sha512 example #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jump, as both the type-checker and translator rely on all arguments being distinct variables
…_block_data_order
…ger accumulate Hobbits variables from the caller
…led on a block with the empty shape
…es a while to run...
eddywestbrook
added
the
subsystem: heapster
m-yac
suggested changes
Nov 23, 2021
m-yac
approved these changes
Nov 23, 2021
m-yac
added
PR: ready to merge
m-yac
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the following Heapster bugs, that were found while trying to get the sha512 example to type-check in Heapster. Note that that example does not yet type-check fully, but these bug fixes are useful to Heapster in general so we are merging them now:
changed
tcJumpTargetto freshen up the argument names in any jump, as both the type-checker and translator rely on all arguments being distinct variableschanged the translation of calls to multi-entry blocks so they no longer accumulate Hobbits variables from the caller
removed an infinite loop in splitLLVMBlockPerm when it is called on a block with the empty shape