-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heapster translation perf improvements #1513
Conversation
…nslation-time assertPermStack* and assertTopPermM checks used during translation
…reduce the number of times name-bindings are converted between fresh function and fresh pair representations
…n-perf-improvements
…that was for an older version of Crucible...
… branch if the first one succeeds
Whoops, I forgot a piece of this PR: the translation of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I did have one nitpick but I don't think it addressing it is worth waiting for the CI to re-run.
…aloisInc/saw-script into heapster/translation-perf-improvements
This PR replaces a number of uses of
fmap
andmbMap2
in the Heapster-to-SAW translation with calls tombMapCl
, in an attempt to reduce the number of times name-bindings are converted between fresh function and fresh pair representations. It also added the commandheapster_set_translation_checks
to turn off the translation-timeassertPermStack*
andassertTopPermM
checks used during translation.