-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the output type of alloca
in heapster
#1491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpaykin
added
the
subsystem: heapster
Issues specifically related to memory verification using Heapster
label
Oct 29, 2021
This branch passes all the tests in the
The code referenced is the following call to
|
…o heapster_alloca_widening_offsets
…o heapster_alloca_widening_offsets
…hen widening two shapes that do not match, return the empty shape, rather than generating a fresh shape variable
jpaykin
changed the title
WIP: Updating the output type of
Updating the output type of Nov 5, 2021
alloca
in heapsteralloca
in heapster
eddywestbrook
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks great! Though we do have to wait for #1496 to get merged before this one.
jpaykin
added
the
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
label
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: ready to merge
Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
subsystem: heapster
Issues specifically related to memory verification using Heapster
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
alloca
command was previously given the following heapster return type:which indicated a block of size
sz
broken up into chunks of sizeM
. However, this produced undesired behavior when allocating data structures whose fields were not all the same size, such as structs. This update givesalloca
an unstructured return type described as amemblock
:This branch is work in progress as I ensure all heapster examples pass and that the change can correctly interpret fields.