Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heapster] Another improvement to widening offsets #1490

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Oct 27, 2021

Building off #1467, this PR makes widening work for offsets which differ by a constant amount > 1 or by a common factor. For example:

uint64_t sum(const uint64_t *arr, size_t len) {
  uint64_t sum = 0;
  while (len--) {
    sum += arr[0];
    arr += 8;
  }
  return sum;
}

(Compared to the example in #1467, arr is now a pointer to a uint64_t and gets incremented by 8 instead of 1.)

Note that this PR also:

... add two more arrays examples (neither of which are fully verified in Coq), fix the translation of `SImpl_LLVMArrayFromBlock`
@m-yac m-yac requested a review from eddywestbrook October 27, 2021 00:51
@m-yac m-yac added the subsystem: heapster Issues specifically related to memory verification using Heapster label Oct 27, 2021
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested two small changes, that are mostly about cleanup. Overall this looks good, though! Great job figuring out the semantics we want for widening!

heapster-saw/src/Verifier/SAW/Heapster/Permissions.hs Outdated Show resolved Hide resolved
heapster-saw/src/Verifier/SAW/Heapster/Permissions.hs Outdated Show resolved Hide resolved
@m-yac m-yac added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Nov 2, 2021
@mergify mergify bot merged commit 0fc5651 into master Nov 2, 2021
@mergify mergify bot deleted the heapster/widening-offsets-1 branch November 2, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants