-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #1489
Update deps #1489
Conversation
bb62b90
to
bf6e453
Compare
bf6e453
to
fbf8e31
Compare
I did add one |
It looks like the test failures are all due to the new def/use analysis claiming that some LLVM virtual register use is not properly dominated by its definition. That suggests to me that there is some bug causing the analysis to be too conservative. |
Well, it looks like I get to spend another afternoon doing builds and tests. I'll bisect and see where this failure was introduced. |
I'm pretty confident it's due to GaloisInc/crucible#886 (in fact, this commit is probably the proximate cause GaloisInc/crucible@c914655) I'm taking a look at the involved bitcode files now to see if there is an obvious cause. |
The two cases I've found that are causing trouble are both 1) generated from rust code and 2) involve the return value of an EDIT: indeed, I'll have to fix this case. The use sets of arguments to invoke and the use sets of the blocks it jumps to are treated the same; however, they need to be handled differently, as the normal return successor block should have the result of the invoke in scope. |
I think that GaloisInc/crucible#895 should resolve this problem. |
5f8bf6f
to
09131cb
Compare
I just reordered some commits and force-pushed a branch without the offending crucible update. I'll test GaloisInc/crucible#895 on top of that separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any real context for the Macaw changes, but this seems OK to me.
I talked separately with @travitch specifically about adapting to GaloisInc/macaw#226, and he agreed that using |
It looks like a couple of tests have failed due to failure to download yices. I'll restart the tests and hopefully they'll work without changes. |
No description provided.