Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heapster] Prove no_errors_mbox_randomize #1478

Merged
merged 4 commits into from
Oct 14, 2021
Merged

[Heapster] Prove no_errors_mbox_randomize #1478

merged 4 commits into from
Oct 14, 2021

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Oct 12, 2021

This PR changes the specification of rand from returnM (intToBv 32 3) to existsM (fun x : bitvector 32 => x) (sorry xkcd.com/221) and adds a proof that mbox_randomize with this updated specification for rand has no errors. This involved adding existsM as a primitive to the saw-core prelude.

eddywestbrook
eddywestbrook approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I know that mbox_randomize proof has been a small annoyance for a while, and it is nice to figure out a good way to handle it!

@m-yac m-yac added subsystem: heapster Issues specifically related to memory verification using Heapster PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Oct 14, 2021
@mergify mergify bot merged commit 83af6c1 into master Oct 14, 2021
@mergify mergify bot deleted the heapster/no_errors_mbox_randomize branch October 14, 2021 19:27
@m-yac m-yac mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywestbrook eddywestbrook eddywestbrook approved these changes

@jpaykin jpaykin Awaiting requested review from jpaykin

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-yac @eddywestbrook