Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow REPL line continuation with \ on Windows #1465

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Allow REPL line continuation with \ on Windows #1465

merged 2 commits into from
Sep 23, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Sep 22, 2021

No description provided.

@atomb atomb added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 22, 2021
robdockins
robdockins approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, assuming it fixes the test issues on Windows.

We should probably open an upstream ticket on haskeline, though, and put a comment here pointing to it so we can remember why this kludge is here and maybe eventually remove it.

@mergify mergify bot merged commit a57d679 into master Sep 23, 2021
@mergify mergify bot deleted the at-windows-backslash branch September 23, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

@brianhuffman brianhuffman Awaiting requested review from brianhuffman

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomb @robdockins