[Heapster] Reduce catchpoints and add more Mbox proofs #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fail are pruned in favor of branches that are guaranteed not to
eddywestbrook
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
The Coq proofs look good! The Haskell code is my own, though, so I'm waiting for someone else (possibly @m-yac himself, who authored this PR) to review.
m-yac
commented
Aug 9, 2021
Comment on lines
3110
to
3112
| mbCombine RL.typeCtxProxies mb_impl1) >>= \trans_pair1 -> | ||
| pitmCatching (translatePermImpl prx $ | ||
| mbCombine RL.typeCtxProxies mb_impl2) >>= \trans_pair2 -> |
There was a problem hiding this comment.
Why not use a pattern matching lambda here (i.e. ... >>= \(mtrans1,hasf1) ->) like you do below (lies 3150 and 3152)?
eddywestbrook
added
the
subsystem: heapster
|
The CI tests all passed before the latest commit, which was just a small tweak and also I tested thoroughly on my local machine, so I am squashing without waiting for the CI. May I be struck down by your angry words if I break the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two parts:
mbox_drop,mbox_concat_chains, andmbox_len.NB: The changes to
arrays.v,clearbufs,v,iter_linked_list.v,mbox.v,rust_lifetimes.v, andstring_set.vare all auto-generated. In a future PR, these auto-generated files are going to be added to the.gitignore.