Bugfix: infinite loop in eliminating an LLVM block permission #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on before eliminating it and would then go right back to trying to eliminate that same permission again...
eddywestbrook
added
the
subsystem: heapster
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to prove
memblock(R,off,len,Sh1<args1>) -o memblock(R,off,len,Sh2<args2>)for an unfoldable nameSh1and an opaque nameSh2, the implication prover would first duplicate theSh1<args1>permission, because it is copyable, unfold it, and then try to proveSh2<args2>, where it would identify thatSh1<args1>permission as a candidate, so it would duplicate it, unfold it, ...The fix is to not duplicate when eliminating a block permission on the left, even if it is copyable.