Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change call site IDs to have an additional Int index #1371

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

eddywestbrook
Copy link
Contributor

This change allows the same source entrypoint to call the same destination entrypoint multiple times and have distinct call sites. This is needed if the latter is a join point and the former performs a disjunctive elimination before doing a call. The resulting bug is showing up in some of our mbox examples.

…ame source entrypoint to call the same destination entrypoint multiple times and have distinct call sites; this is needed if the latter is a join point and the former performs a disjunctive elimination before doing a call
@eddywestbrook eddywestbrook requested review from glguy and m-yac July 8, 2021 00:25
@eddywestbrook eddywestbrook added the subsystem: heapster Issues specifically related to memory verification using Heapster label Jul 8, 2021
Copy link
Member

@glguy glguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense and match the comments and names. I don't know how to run this and verify that it improves an old behavior.

@eddywestbrook eddywestbrook added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jul 8, 2021
@mergify mergify bot merged commit 6768d20 into master Jul 8, 2021
@mergify mergify bot deleted the bugfix/heapster-indexed-call-sites branch July 8, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants