Improvements to the Heapster Rust translation #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 30, 2021 15:16
…e qualified with their crates; changed the Rust type translation to use this qualification by translating Rust names in a fully qualified way
…er_define_rust_type_qual to the last commit; also changed parseAndInsDef to not fail when an identifier is already being used, but to instead generate a new, unused identifier
…on, as an example in rust_data
…n a recursive type cannot be handled
…er to implement a bug fix for heapster_define_rust_type to print out an error message when a recursive type cannot be handled
eddywestbrook
added
the
subsystem: heapster
ChrisEPhifer
approved these changes
Jul 1, 2021
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the command
heapster_define_rust_type_qualto qualify the names of Rust types when we define them, to allow, e.g., bothResutandfmt::Resultto exist at the same time.Fixed a bug in
heapster_define_rust_typewhere it would give a weird, incomprehensible error message for recursive Rust types it cannot handleA few other small tweaks and bug fixes