Improve scAbstractExts and scGeneralizeExts
#1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
approved these changes
Jun 14, 2021
Previously, these functions were not working correctly when the _types_ of some `ExtCns` values mention some of the `ExtCns` values being abstracted or generalized. Now we are careful to both evaluate inside the types of `ExtCns` values occuring inside the term, as well as making sure that the types of `ExtCns` values in the list are processed properly in the context of the outer values.
robdockins
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these functions were not working correctly when
the types of some
ExtCnsvalues mention some of theExtCnsvalues being abstracted or generalized. Now we arecareful to both evaluate inside the types of
ExtCnsvaluesoccuring inside the term, as well as making sure that the
types of
ExtCnsvalues in the list are processed properlyin the context of the outer values.
This patch is split off from #1298