Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark jvm_* commands as "Current" instead of "Experimental". #1300

Merged
merged 3 commits into from
May 19, 2021
Merged

Mark jvm_* commands as "Current" instead of "Experimental". #1300

merged 3 commits into from
May 19, 2021

Conversation

brianhuffman
Copy link
Contributor

Fixes #1299.

@brianhuffman brianhuffman requested review from robdockins and atomb May 19, 2021 02:49
RyanGlScott
RyanGlScott approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserves a mention in the changelog, but other than that, LGTM.

robdockins
robdockins approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Changelog mention would be nice, otherwise 👍

atomb
atomb approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to a changelog entry, but otherwise great

@brianhuffman
Copy link
Contributor Author

I added changelog entries about the experimental/current change and a couple of other recent changes to JVM verification.

@brianhuffman brianhuffman added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label May 19, 2021
@mergify mergify bot merged commit cbd9223 into master May 19, 2021
@mergify mergify bot deleted the jvm-current branch May 19, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark JVM verification commands as current
4 participants
@brianhuffman @atomb @RyanGlScott @robdockins