Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft contributor guidelines #1292

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Add draft contributor guidelines #1292

merged 5 commits into from
Jun 1, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented May 14, 2021

This PR includes a draft CONTRIBUTING.md with guidelines for developing with SAW. I imagine it's missing or misstating things, as-is, but opening it up for review is probably the quickest way to resolve that.

Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, adding the CODE_OF_CONDUCT add specific obligations that we are required to fulfill. I'm personally not opposed to the principles here in any way, but by explicitly stating them we are essentially creating a contract; we might want to have our legal/contracts folks verify this before posting it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@lisanna-dettwyler
Copy link
Contributor

As a general comment, adding the CODE_OF_CONDUCT add specific obligations that we are required to fulfill. I'm personally not opposed to the principles here in any way, but by explicitly stating them we are essentially creating a contract; we might want to have our legal/contracts folks verify this before posting it.

Maybe it's also something we have a larger conversation about? Also not opposed to having them but it might be one of those things that some people might be more opinionated about than others, and having our own galois-centric one could be nice.

@atomb atomb added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label May 28, 2021
@atomb atomb force-pushed the at-contributing branch from ba71049 to 3c5c52c Compare May 28, 2021 19:26
Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point soon I'd like to add a section to CONTRIBUTING.md showing how to get different kinds of changes integrated into master with feature flags, so people don't need to have long-lived nightmare branches/forks.

CONTRIBUTING.md Outdated
# Code of Conduct

This project adheres to the [Contributor Covenant code of
conduct](CODE_OF_CONDUCT.md). By participating, you are expected to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead link

@mergify mergify bot merged commit 7ee6c7d into master Jun 1, 2021
@mergify mergify bot deleted the at-contributing branch June 1, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants