-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft contributor guidelines #1292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment, adding the CODE_OF_CONDUCT add specific obligations that we are required to fulfill. I'm personally not opposed to the principles here in any way, but by explicitly stating them we are essentially creating a contract; we might want to have our legal/contracts folks verify this before posting it.
Maybe it's also something we have a larger conversation about? Also not opposed to having them but it might be one of those things that some people might be more opinionated about than others, and having our own galois-centric one could be nice. |
We may put a custom one in place later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point soon I'd like to add a section to CONTRIBUTING.md showing how to get different kinds of changes integrated into master with feature flags, so people don't need to have long-lived nightmare branches/forks.
CONTRIBUTING.md
Outdated
# Code of Conduct | ||
|
||
This project adheres to the [Contributor Covenant code of | ||
conduct](CODE_OF_CONDUCT.md). By participating, you are expected to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead link
This PR includes a draft
CONTRIBUTING.md
with guidelines for developing with SAW. I imagine it's missing or misstating things, as-is, but opening it up for review is probably the quickest way to resolve that.