JVM write permissions #1290
Merged
JVM write permissions #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
May 13, 2021
atomb
reviewed
May 13, 2021
atomb
approved these changes
May 14, 2021
|
It looks like there's a build failure caused by one of the crucible PRs that snuck in between my two crucible PRs. I'll have to make a separate bump-submodules PR to fix that, and merge it ahead of this one. |
added 7 commits
May 18, 2021 18:06
brianhuffman
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new
crucible-jvmwrite permissions added in GaloisInc/crucible#733 and GaloisInc/crucible#735 to fix the soundness issues #900 and #1066.I'll keep this in a draft state until those crucible PRs are merged.