Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use read_only=True in test_salsa20.py #1282

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Use read_only=True in test_salsa20.py #1282

merged 1 commit into from
Apr 30, 2021

Conversation

RyanGlScott
Copy link
Contributor

In addition, test Salsa20CryptContract on more inputs, just like the SAWScript version does, to make sure that it is working robustly.

Fixes #1280.

@RyanGlScott
Use read_only=True in test_salsa20.py
7d4268a 
In addition, test `Salsa20CryptContract` on more inputs, just like the
SAWScript version does, to make sure that it is working robustly.

Fixes #1280.
pnwamk
pnwamk approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@pnwamk pnwamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanGlScott RyanGlScott added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Apr 30, 2021
@mergify mergify bot merged commit 130a107 into master Apr 30, 2021
@mergify mergify bot deleted the T1280 branch April 30, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnwamk pnwamk pnwamk approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
2 participants
@RyanGlScott @pnwamk