Adapt to cryptol PR #1128 "persist-solver2" #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly consists of commenting-out the `validateSAWState` function. It doesn't apper to have any call sites, so I'm not sure what it is intended to be used for.
robdockins
force-pushed
the
persist-solver2
branch
from
2017180 to
8615fc0
Compare
robdockins
added
the
PR: keep updated
robdockins
added
PR: ready to merge
|
It's worth noting that this PR doesn't actually use a persistent solver connection, it just updates the API uses. |
|
There a python-level error in the failing test here. https://github.com/GaloisInc/saw-script/pull/1267/checks?check_run_id=2615159214#step:14:76 I can't tell if this is related to my changes or not. @pnwamk, any insights? |
|
Well, fresh build looks like it passed, so I'm going to chalk that up to transient failure. |
pnwamk
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes patches that adapt the saw-core package (taken from GaloisInc/saw-core#197) and saw-script package to work with GaloisInc/cryptol#1128, which adds support for a persistent solver connection for cryptol type checking (see #953).
However, this PR is not yet finished because the
saw-remote-apipackage still needs to be adapted.