Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix docker image uploads, don't allow confusion over Dockerfiles #1077

Merged
merged 2 commits into from
Feb 16, 2021
Merged

chore: fix docker image uploads, don't allow confusion over Dockerfiles #1077

merged 2 commits into from
Feb 16, 2021

Conversation

pnwamk
Copy link
Contributor

@pnwamk pnwamk commented Feb 15, 2021

These changes remove some extra Dockerfiles and should fix the current Docker image CI creation/upload and help us avoid any future ambiguity of having two Dockerfiles in the root directory by nesting them under their respective applications directories.

For any curuious, note that https://github.com/docker/build-push-action@v1 uses dockerfile: FILE to specify a custom Dockerfile... while @v2 switched things up to use file: FILE (we're on v1 at the moment).

@pnwamk pnwamk requested review from atomb and hazelweakly February 15, 2021 23:14
@pnwamk pnwamk added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Feb 16, 2021
lisanna-dettwyler
lisanna-dettwyler reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@lisanna-dettwyler lisanna-dettwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and cleaning this up!

saw-remote-api/Dockerfile Outdated Show resolved Hide resolved
@pnwamk pnwamk force-pushed the fix-remote-dockerfile branch from 0ed9af8 to d5b5eae Compare February 16, 2021 19:43
@pnwamk pnwamk added PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run and removed PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels Feb 16, 2021
@pnwamk
Copy link
Contributor Author

pnwamk commented Feb 16, 2021

FYI, while this PR fixes some issues and gets us closer to where we want these docker image builds to be, there's still some issues currently being worked on by @LisannaAtGalois w.r.t. the nightly/docker builds failing.

@pnwamk pnwamk mentioned this pull request Feb 16, 2021
Merged
@pnwamk pnwamk merged commit 31d691b into master Feb 16, 2021
@pnwamk pnwamk deleted the fix-remote-dockerfile branch February 16, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisanna-dettwyler lisanna-dettwyler lisanna-dettwyler left review comments

@hazelweakly hazelweakly hazelweakly approved these changes

@atomb atomb Awaiting requested review from atomb

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnwamk @hazelweakly @lisanna-dettwyler