Embed JVMSetupError inside TopLevelException datatype. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
added
the
PR: ready to merge
brianhuffman
added
the
PR: keep updated
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
a19e017 to
3960578
Compare
brianhuffman
removed
the
PR: keep updated
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
3960578 to
090b21c
Compare
This means that JVMSetupError exceptions can now be caught by the standard TopLevelException handlers, and get shown with the expected stack traces in the saw-script REPL. This is done using a new existentially-typed `SomeTopLevelException` constructor, as recommended by the Control.Exception documentation. Fixes #1021.
brianhuffman
force-pushed
the
jvm-setup-error
branch
from
090b21c to
a47c087
Compare
atomb
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that JVMSetupError exceptions can now be caught by
the standard TopLevelException handlers, and get shown with
the expected stack traces in the saw-script REPL.
This is done using a new existentially-typed
SomeTopLevelExceptionconstructor, as recommended by the Control.Exception documentation.
Fixes #1021.