Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test0001 to actually prove the MD5 spec, using jvm_verify. #1011

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Update test0001 to actually prove the MD5 spec, using jvm_verify. #1011

merged 2 commits into from
Jan 19, 2021

Conversation

brianhuffman
Copy link
Contributor

Fixes #1009.

@brianhuffman brianhuffman requested a review from atomb January 16, 2021 01:20
@brianhuffman brianhuffman mentioned this pull request Jan 16, 2021
Merged
atomb
atomb approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I hope soon we can get rid of the other skipped tests in CI.

@brianhuffman brianhuffman merged commit 093a788 into master Jan 19, 2021
@brianhuffman brianhuffman deleted the test0001 branch January 19, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix test0001 so that it actually verifies the Java MD5 implementation
2 participants
@brianhuffman @atomb