Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support byte/char/short in JVM verification commands. #1008

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Support byte/char/short in JVM verification commands. #1008

merged 3 commits into from
Jan 15, 2021

Conversation

brianhuffman
Copy link
Contributor

Fixes #1006.

@brianhuffman brianhuffman requested a review from atomb January 15, 2021 00:19
@brianhuffman brianhuffman mentioned this pull request Jan 15, 2021
Merged
atomb
atomb approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@atomb atomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

@brianhuffman brianhuffman merged commit 6789b1a into master Jan 15, 2021
@brianhuffman brianhuffman deleted the jvm-byte-char branch January 26, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomb atomb atomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JVM spec commands don't work with byte and char types
2 participants
@brianhuffman @atomb