Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization of Crucible/LLVM related modules #455

Closed
langston-barrett opened this issue May 21, 2019 · 3 comments · Fixed by #482
Closed

Organization of Crucible/LLVM related modules #455

langston-barrett opened this issue May 21, 2019 · 3 comments · Fixed by #482
Assignees
Labels
subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm

Comments

@langston-barrett
Copy link
Contributor

Right now, we have a few Crucible/LLVM modules in the top level under SAWScript that should probably have their own submodule/path structure. This would both suggest that they are related (they are) and differentiate them from Crucible/JVM material. I'd suggest the following:

  • CrucibleOverride -> LLVM.Overrides
  • CrucibleLLVM -> LLVM.Crucible
  • CrucibleBuiltins -> LLVM.Builtins
  • CrucibleMethodSpecIR -> LLVM.MethodSpec
  • CrucibleResolveSetupValue -> LLVM.SetupValue
@atomb
Copy link
Contributor

atomb commented May 21, 2019

👍

@brianhuffman
Copy link
Contributor

See also #379. At some point we'll want to factor out the common functionality in the crucible-llvm and crucible-jvm parts of saw-script. So we should also think about how the modules ought to be organized once that's done.

@langston-barrett langston-barrett self-assigned this Jun 7, 2019
langston-barrett added a commit to langston-barrett/saw-script that referenced this issue Jun 7, 2019
@langston-barrett langston-barrett added the subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm label Jun 7, 2019
@langston-barrett
Copy link
Contributor Author

@brianhuffman I've started considering that question on a branch: https://github.com/siddharthist/saw-script/tree/crucible-llvm-jvm.

I made the module hierarchy with the following idea in mind:

  • SAWScript.Crucible has all Crucible-specific code
  • SAWScript.Crucible.<lang> has crucible- specific code
  • SAWScript.Crucible.Common has non-language specific code

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants