Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting SAW options from Python client #1493

Closed
RyanGlScott opened this issue Nov 2, 2021 · 1 comment · Fixed by #1538
Closed

Allow setting SAW options from Python client #1493

RyanGlScott opened this issue Nov 2, 2021 · 1 comment · Fixed by #1538
Assignees
@RyanGlScott
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability

Comments

@RyanGlScott
Copy link
Contributor

The SAW remote API has the capability to toggle SAW-specific options in SAWServer.SetOption. Currently, there is no way to utilize this functionality from the Python client, however. We should add this.
@RyanGlScott RyanGlScott added subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability labels Nov 2, 2021
@RyanGlScott
Copy link
Contributor Author

This is a prerequisite to supporting bitfields (#1461) in Python. Since I'm working on #1461, I'll assign myself to this issue as well.

@RyanGlScott RyanGlScott self-assigned this Dec 8, 2021
@RyanGlScott RyanGlScott mentioned this issue Dec 8, 2021
Closed
RyanGlScott added a commit that referenced this issue Dec 8, 2021
@RyanGlScott
saw-client: Support setting SAW options
baa04b8 
This adds a `set_option` function to the `saw_client` module that controls
whether various global SAW options should be enabled or disabled. The possible
options that can be controlled are found in the `saw_client.option` module.

Fixes #1493.
RyanGlScott added a commit that referenced this issue Dec 8, 2021
@RyanGlScott
Add What4 eval to saw-remote-api and saw-client
f0cc92d 
The infrastructure for doing so was already in place in `saw-remote-api`, and
thanks to #1493, the infrastructure for adding this functionality in the
Python `saw-client` library is now in place as well.

Fixes #1537.
@RyanGlScott RyanGlScott mentioned this issue Dec 8, 2021
Merged
RyanGlScott added a commit that referenced this issue Dec 10, 2021
@RyanGlScott
saw-client: Support setting SAW options
5c282c8 
This adds a `set_option` function to the `saw_client` module that controls
whether various global SAW options should be enabled or disabled. The possible
options that can be controlled are found in the `saw_client.option` module.

Fixes #1493.
RyanGlScott added a commit that referenced this issue Dec 10, 2021
@RyanGlScott
Add What4 eval to saw-remote-api and saw-client
e8b082d 
The infrastructure for doing so was already in place in `saw-remote-api`, and
thanks to #1493, the infrastructure for adding this functionality in the
Python `saw-client` library is now in place as well.

Fixes #1537.
@mergify mergify bot closed this as completed in #1538 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanGlScott RyanGlScott

Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: feature request Issues requesting a new feature or capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

saw-remote-api: Reach parity with SAWScript for global option settings GaloisInc/saw-script
1 participant
@RyanGlScott