Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type construction #1119

Closed
robdockins opened this issue Mar 11, 2021 · 0 comments
Closed

Incorrect type construction #1119

robdockins opened this issue Mar 11, 2021 · 0 comments
Labels
type: bug Issues reporting bugs or unexpected/unwanted behavior

Comments

@robdockins
Copy link
Contributor

saw-script/src/SAWScript/Crucible/LLVM/Override.hs

Line 1234 in 9da72c5

scTuple sc fields'

This line interprets the type of a crucible structure value as a tuple. Note! This is the constructor for tuple values, not tuple types, which is an error. Plugging in the resulting term in a type-position will result in ill-typed terms. This should use the scTupleType method instead.
@robdockins robdockins added the type: bug Issues reporting bugs or unexpected/unwanted behavior label Mar 11, 2021
robdockins added a commit that referenced this issue Mar 11, 2021
@robdockins
Fix an issue caused by an incorrect type construcion.
d64a9f5 
The tuple _value_ constructor was being used instead of the
tuple _type_ constructor, which was causing an ill-typed
term to be emitted.

Fixes #1119
@mergify mergify bot closed this as completed in 33fa847 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robdockins