Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow llvm_assert_eq to be used with function arguments #106

Closed
atomb opened this issue Mar 2, 2016 · 2 comments
Closed

Allow llvm_assert_eq to be used with function arguments #106

atomb opened this issue Mar 2, 2016 · 2 comments
Assignees
Labels
priority High-priority issues

Comments

@atomb
Copy link
Contributor

atomb commented Mar 2, 2016

At the moment, if you say llvm_assert_eq "x" {{ ... }}, where x is a function argument, you'll get the error message "argument assignments not allowed". There's no deep reason why it couldn't be supported, though.

@atomb atomb self-assigned this Mar 16, 2016
@atomb atomb added the priority High-priority issues label Mar 30, 2016
@atomb atomb added this to the 0.2-alpha milestone Mar 30, 2016
@atomb atomb removed this from the 0.2-alpha milestone Apr 11, 2016
@atomb
Copy link
Contributor Author

atomb commented Apr 11, 2016

This will be best supported by the refactoring happening in the llvm_verify_exp branch. That work won't be done by the 0.2-alpha release, unfortunately, so I'm removing that milestone from this ticket.

@atomb
Copy link
Contributor Author

atomb commented Apr 14, 2016

As it turns out, we managed to merge the llvm_verify_exp branch into the 0.2 release. On top of those changes, commit cf0e50f fixes the issue with llvm_assert_eq and function arguments (though this unfortunately didn't make the release).

@atomb atomb closed this as completed Apr 14, 2016
brianhuffman pushed a commit that referenced this issue Apr 26, 2021
Switch from ansi-wl-pprint to the prettyprinter package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority High-priority issues
Projects
None yet
Development

No branches or pull requests

1 participant