This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Support uninterpreted polymorphic functions in sbv/what4 backends. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by declaring monomorphic uninterpreted functions at each type instance, using a name suffix based on the type value. Fixes GaloisInc/saw-script#320.
brianhuffman
force-pushed
the
unint-poly
branch
from
ad8c91b to
a489c57
Compare
brianhuffman
force-pushed
the
unint-poly
branch
from
b92fafd to
7049e5c
Compare
robdockins
reviewed
Oct 20, 2020
| -- | A (partial) injective mapping from type values to strings. These | ||
| -- are intended to be useful as suffixes for names of type instances | ||
| -- of uninterpreted constants. | ||
| suffixTValue :: TValue sym -> Maybe String |
There was a problem hiding this comment.
Is this function for selecting type-based suffixes injective? I think it is, but it isn't immediately clear.
There was a problem hiding this comment.
Yes, it is. Basically it serializes the TValue with a pre-order traversal, and all the strings it uses to represent the nodes are distinct. So you could always unambiguously parse them back in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by declaring monomorphic uninterpreted functions at
each type instance, using a name suffix based on the type value.
Fixes GaloisInc/saw-script#320.