This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Avoid calling slow typeInferComplete on already-typechecked terms.
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a performance problem that was exposed by #118: `typeInferComplete` is actually very slow when called on `Constant` terms, because instead of using the cached type, it rechecks the well-formedness of the constant's definition. Furthermore, its memoization for observable sharing is mostly ineffective, because it resets the memo table whenever it looks under a binder. Switching from `typeInferComplete` to `scTypeOf` brings the saw-script start-up time back to where it was before #118.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance problem that was exposed by #118:
typeInferCompleteis actually very slow when called onConstantterms, because instead of using the cached type,it rechecks the well-formedness of the constant's definition.
Furthermore, its memoization for observable sharing is mostly
ineffective, because it resets the memo table whenever it
looks under a binder.
Switching from
typeInferCompletetoscTypeOfbrings thesaw-script start-up time back to where it was before #118.