-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement macaw-riscv-symbolic
#411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary plumbing to simulate Macaw-lifted RISC-V binaries using `macaw-symbolic`. This proves relatively straightforward, given that RISC-V does not have a lot of special primitive functions or statements to deal with. I have also added a basic test suite to ensure that `macaw-riscv-symbolic` works on end-to-end examples. Fixes #409.
RyanGlScott
added
symbolic-execution
Issues relating to macaw-symbolic and symbolic execution
arch:riscv
RISC-V issues
labels
Jul 26, 2024
kquick
approved these changes
Jul 26, 2024
Ptival
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't follow all details, but overall this all looks reasonable to me.
macaw-riscv-symbolic/src/Data/Macaw/RISCV/Symbolic/Functions.hs
Outdated
Show resolved
Hide resolved
…rror See #412 for the remaining task of allowing the return types of `GenArchVals`' `{lookup,update}Reg` functions to indicate the possibility of an error.
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Jul 26, 2024
This bumps the `macaw` submodule to bring in the changes from GaloisInc/macaw#411, which is a prerequisite to being able to implement `macaw-loader-riscv` (see #13). This also requires bumping the `crucible`, `elf-edit`, `llvm-pretty`, and `what4` submodules in order to construct a build plan that is consistent with the latest `macaw` commit.
RyanGlScott
added a commit
to GaloisInc/macaw-loader
that referenced
this pull request
Jul 26, 2024
This bumps the `macaw` submodule to bring in the changes from GaloisInc/macaw#411, which is a prerequisite to being able to implement `macaw-loader-riscv` (see #13). This also requires bumping the `crucible`, `elf-edit`, `llvm-pretty`, and `what4` submodules in order to construct a build plan that is consistent with the latest `macaw` commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arch:riscv
RISC-V issues
symbolic-execution
Issues relating to macaw-symbolic and symbolic execution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary plumbing to simulate Macaw-lifted RISC-V binaries using
macaw-symbolic
. This proves relatively straightforward, given that RISC-V does not have a lot of special primitive functions or statements to deal with. I have also added a basic test suite to ensure thatmacaw-riscv-symbolic
works on end-to-end examples.Fixes #409.