Tweaks to the DebugUtils module #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes expose a bit more information gleaned from the debug information about types from the source program.
elliottt
approved these changes
Feb 11, 2022
Comment on lines
-271
to
-273
| Maybe [Info] {- ^ return and argument type information -} | ||
| Maybe [Maybe Info] {- ^ return and argument type information -} | ||
| computeFunctionTypes m sym = | ||
| [ maybe (BaseType "void") (valMdToInfo mdMap) <$> types |
There was a problem hiding this comment.
Does this change mean that void is now represented as Nothing?
There was a problem hiding this comment.
Right. I believe that is more faithful to the DWARF encoding.
Perhaps? I'm not sure how much has accumulated since the last release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes expose a bit more information gleaned from the debug
information about types from the source program.
This changes the type of
computeFunctionTypesto be a bit more accurate, I think. I don't know of any use sites for this function, so I don't know how disruptive this will be.