-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building Heapster shapes from Rust type declarations #85
Conversation
…version of RustNames. NOTE: Does not compile due to downstream effects of these changes
@eddywestbrook I believe this is ready to go! All of the examples in Once we get this merged I'll tag you in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicky things:
- Please add a Haddock to
isRecursiveDef
- Maybe change the Haddock for
parseLLVMShapeFromRust
to say that it is parsing a type definition or declaration or whatever you think the correct noun is. It's a bit confusing (at least to me) to say it is parsing types, because other code in the same module does in fact parse types to shapes - And on a similar note, maybe change the name of
parseLLVMShapeFromRust
to something likeparseNamedShapeFromRustDecl
orparseRustTypeDecl
orrsParseConvertTypeDecl
or something like that
Nits have been picked :) Gonna merge this in! |
This PR adds a number of
RsConvert
instances and a simple parser entry-point to support the synthesis of Heapster shapes from Rust types.Marked as WIP as I implement the saw-script side of things (adding a command to interface with these features); there is a branch off
wip-heapster
for that work, named the same as this one (feature/rust-type-decls
).