Tc errors #964
Merged
Tc errors #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are broken at this commit
This should go some way toward solving #782, although there are still funny numbers from quantified variables. Note the tests do not yet work, as the error messages are all different and I'll change them only when I finalize the new error messages
brianhuffman
pushed a commit
to GaloisInc/saw-core
that referenced
this pull request
Nov 19, 2020
brianhuffman
pushed a commit
to GaloisInc/saw-core
that referenced
this pull request
Nov 20, 2020
Adapt to GaloisInc/cryptol#964 tc-errors.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 20, 2020
This includes GaloisInc/cryptol#964 as well as GaloisInc/saw-core#104, which adapts cryptol-saw-core to the changes in cryptol.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 20, 2020
This includes GaloisInc/cryptol#964 as well as GaloisInc/saw-core#104, which adapts cryptol-saw-core to the changes in cryptol.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 20, 2020
brianhuffman
pushed a commit
to GaloisInc/crucible
that referenced
this pull request
Nov 22, 2020
The submodule updates include GaloisInc/cryptol#964 and GaloisInc/saw-core#104.
brianhuffman
pushed a commit
to GaloisInc/crucible
that referenced
this pull request
Nov 24, 2020
The submodule updates include GaloisInc/cryptol#964 and GaloisInc/saw-core#104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress toward fixing #905 and #782
#905 is fixed because we simply don't have
TCErrorMessageanymore, it really wasn't adding any useful informationthat we can't recover when pretty printing an unsolved constraint.
#782 is improved because unificaiton variables are printed in a normalized form, although internal unique identifiers are still
visible in the printing of quantified variables.