Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support literal 0 and 1 at type Bit. #914

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Support literal 0 and 1 at type Bit. #914

merged 3 commits into from
Sep 29, 2020

Conversation

brianhuffman
Copy link
Contributor

Fixes #913.

Brian Huffman added 3 commits September 29, 2020 10:47
@brianhuffman brianhuffman requested a review from yav September 29, 2020 18:06
yav
yav approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We really should prioritize fixing #782 though :)

@brianhuffman
Copy link
Contributor Author

brianhuffman commented Sep 29, 2020 •
edited
Loading

Yeah, those type variable number changes really obscure the one important change in that file: number`{rep = Bit} is now inferred to have type {n} (1 >= n) => Bit instead of causing a type error. I went ahead and tagged #782 with the "priority" label.

@brianhuffman brianhuffman merged commit ec9a8ba into master Sep 29, 2020
@brianhuffman brianhuffman deleted the literal-bit branch September 29, 2020 19:17
brianhuffman pushed a commit to GaloisInc/saw-core that referenced this pull request Sep 29, 2020
Adapt to Literal instance for type Bit in GaloisInc/cryptol#914.
f258760
brianhuffman pushed a commit to GaloisInc/saw-core that referenced this pull request Sep 29, 2020
Merge pull request #73 from GaloisInc/update-cryptol
920a014 
Adapt to Literal instance for type Bit in GaloisInc/cryptol#914.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Literal 0 and 1 at type Bit
2 participants
@brianhuffman @yav