Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue838 #904

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Issue838 #904

merged 3 commits into from
Sep 23, 2020

Conversation

brianhuffman
Copy link
Contributor

Make Cryptol REPL accept input lines containing only comments.

Fixes #838.

@brianhuffman brianhuffman requested a review from yav September 23, 2020 14:29
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We could probably remove the %name letDecl entry point to the parser as the repl?
  • Maybe add a comment to repl that this is not a part of the language, but rather it is used by the repl (the name is quite suggestive, of course :-)

@brianhuffman
Copy link
Contributor Author

As for %name letDecl: This, and the parseLetDecl and parseLetDeclWith functions, are part of the cryptol-as-a-library API; even if we're not using these internally for the cryptol REPL, they might be useful to other packages that use cryptol.

@yav
Copy link
Member

yav commented Sep 23, 2020

Is it though? That API is not written down anywhere. If you know that one of our tools is using it, let's keep it by all means. Otherwise, I think we should remove it as this is really not part of Cryptol the language, it just happens to be the notation we use on the text REPL (ideally it should be in a separate parser, but I don't think that happy has support for modularity...)

@brianhuffman
Copy link
Contributor Author

I just did a search, and it appears that parseLetDecl is not used anywhere in saw-script or any of its dependencies. So it should be safe to remove it. But that's not directly related to this PR, so let's do it in a separate one.

Brian Huffman added 3 commits September 23, 2020 09:10
Apparently multi-line REPL input is not supported on all platforms
(Windows in particular).
@brianhuffman brianhuffman merged commit 8d3f10a into master Sep 23, 2020
@RyanGlScott RyanGlScott deleted the issue838 branch March 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments at the REPL
2 participants