Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch evaluation environment from Data.Map to Data.IntMap. #884

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

brianhuffman
Copy link
Contributor

Benchmarks using examples/AES.cry and Primitive/Keyless/Hash/SHA1.cry from the cryptol-examples repo show that using IntMap instead of Map for the value environment yields a speedup of about 7 or 8 percent, and a reduction in memory footprint of about 4 or 5 percent.

@robdockins
Copy link
Contributor

We're already doing the working of computing unique names, so this seems like a pretty straightforward way to squeeze out some performance. I'm looking into doing basically the same for the types environment (type evaluation consumes a surprising amount of time for some workloads).

@brianhuffman brianhuffman merged commit 0000ffb into master Sep 10, 2020
@RyanGlScott RyanGlScott deleted the eval-intmap branch March 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants